feat: Token validity check #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
Thanks to @sparkoo for spotting this. I would have never found this...
metlos
requested review from
flacatus,
mmorhun and
nickboldt
as code owners
tolusha
approved these changes
Sep 30, 2021
sparkoo
reviewed
Sep 30, 2021
|
/retest |
sparkoo
approved these changes
Sep 30, 2021
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: metlos, sparkoo, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds a check for token validity on OpenShift in native user mode. This prevents the unauthenticated traffic from even reaching the endpoints backed by the gateway. Note that the workspace endpoints handled by the gateway already contain similar configuration. This PR adds it also to the authenticated server endpoints, like
/api. The unauthenticated endpoints like/devfile-registryare not affected.Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#20304
How to test this PR?
Follow the instructions on the above mentioned issue. Instead of 500, the server should now return 401 Unauthorized HTTP status code.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.